Removing Material from slider #1244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eact into jialecl-removingMaterial-slider
…eact into jialecl-removingMaterial-slider
marcialfps
requested review from
marcialfps
and removed request for
GomezIvann
marcialfps
requested changes
Sep 6, 2022
There was a problem hiding this comment.
Other changes
-
I think we should be consistent in how we implement all the components. In your case you are setting the type next to the styled component, I propose you create types for each one naming them as
XXXXPropsType. -
The disabled tracker changes its styles when clicked.
-
Add new tests:
- Test case for all accessibility attributes.
- Test cases for all keyboard interactions.
- Test case we saw in the call:
minValue={5} maxValue={50} step={10}. Verify that the maximum value is 45.
marcialfps
requested changes
Sep 20, 2022
There was a problem hiding this comment.
- As I said in the previous comment:
- Add test case for ALL accessibility attributes, including:
aria-labelledby,aria-orientation,aria-valuemax,aria-valuemin,aria-valuenow. This should be added to the first test case, not others. If you need an example, take a look to the first test case from Radio Group component. - The disabled tracker changes its styles when clicked.
- Add test case for ALL accessibility attributes, including:
marcialfps
reviewed
Sep 20, 2022
marcialfps
approved these changes
Sep 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.