Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Major] Removed Material UI dependencies from Dropdown #1245

Merged
merged 15 commits into from Sep 9, 2022

Conversation

GomezIvann
Copy link
Collaborator

@GomezIvann GomezIvann commented Aug 23, 2022

Summary of behaviour changes of the component regarding the original:

  1. New box-shadow to match other components with a list of Halstack.
  2. Dropdown menu has been reimplemented as a Portal using Radix UI Popover, similar to how it was done with the select.
  3. Accessibility roles and attributes are preserved as much as possible, adding new ones following W3C guidelines for the active descendant pattern.
  4. Menu transitions for opening and closing have been removed.
  5. Keyboard Support has been preserved, adding new ones such as Esc, Home, PageUp, End, PageDown, etc. For this, I've followed W3C accessibility guidelines for Menu Buttons (Dropdown pattern).
  6. Storybooks and Jest tests have been rewritten and incremented to match the new implementation and catch possible future errors.

@GomezIvann GomezIvann self-assigned this Aug 23, 2022
@GomezIvann GomezIvann assigned GomezIvann and unassigned GomezIvann Aug 25, 2022
@GomezIvann GomezIvann removed their assignment Aug 26, 2022
@GomezIvann GomezIvann linked an issue Aug 30, 2022 that may be closed by this pull request
@marcialfps marcialfps self-assigned this Sep 2, 2022
lib/src/dropdown/Dropdown.tsx Show resolved Hide resolved
lib/src/dropdown/Dropdown.tsx Show resolved Hide resolved
lib/src/dropdown/DropdownMenu.tsx Show resolved Hide resolved
lib/src/dropdown/Dropdown.tsx Outdated Show resolved Hide resolved
lib/src/dropdown/Dropdown.tsx Show resolved Hide resolved
lib/src/dropdown/Dropdown.test.js Outdated Show resolved Hide resolved
lib/src/dropdown/Dropdown.test.js Show resolved Hide resolved
lib/src/dropdown/Dropdown.test.js Show resolved Hide resolved
lib/src/dropdown/Dropdown.test.js Show resolved Hide resolved
lib/src/dropdown/Dropdown.stories.tsx Outdated Show resolved Hide resolved
marcialfps
marcialfps previously approved these changes Sep 7, 2022
Copy link
Collaborator

@marcialfps marcialfps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@marcialfps marcialfps merged commit 420b045 into master Sep 9, 2022
@marcialfps marcialfps deleted the gomezivann-dropdown-refactor branch September 9, 2022 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Material UI dependencies from Dropdown
2 participants