Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Material UI dependencies from Accordion and Accordion Group #1267

Merged
merged 13 commits into from Sep 22, 2022
Merged

Remove Material UI dependencies from Accordion and Accordion Group #1267

merged 13 commits into from Sep 22, 2022

Conversation

GomezIvann
Copy link
Collaborator

@GomezIvann GomezIvann commented Sep 15, 2022 •
edited

Summary of changes:

  1. The HTML structure of the component has been completely overwritten to match the current W3C design pattern for accordions. Now the component has two main parts: the Accordion Header (an h3 tag with a button inside) and the Accordion Panel (regular div for the custom content).
  2. Accordion Group has also been updated, removing the Material selectors and replacing them for regular CSS.
  3. Added accessibility attributes to the component, following the aria specifications of W3C.
  4. Updated stories and Jest testing.

@GomezIvann GomezIvann changed the title Remove Material UI from Accordion and Accordion Group Remove Material UI dependencies from Accordion and Accordion Group Sep 15, 2022
@GomezIvann GomezIvann linked an issue Sep 15, 2022 that may be closed by this pull request
Remove Material UI dependencies from Accordion #1195
Closed
@GomezIvann GomezIvann self-assigned this Sep 15, 2022
@GomezIvann GomezIvann removed their assignment Sep 15, 2022
@aidamag aidamag self-assigned this Sep 20, 2022
@aidamag
Copy link
Contributor

aidamag commented Sep 21, 2022

What do you think about adding hover, active and focus stories for accordion group?

@aidamag aidamag merged commit 7f5e42c into master Sep 22, 2022
@aidamag aidamag deleted the gomezivann-accordion-material branch September 22, 2022 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aidamag aidamag aidamag approved these changes

Assignees

@aidamag aidamag

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove Material UI dependencies from Accordion
2 participants
@GomezIvann @aidamag