Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update component's size fitContent #1303

Merged
merged 2 commits into from Oct 3, 2022
Merged

Update component's size fitContent #1303

merged 2 commits into from Oct 3, 2022

Conversation

aidamag
Copy link
Contributor

@aidamag aidamag commented Sep 22, 2022

No description provided.

@aidamag aidamag self-assigned this Sep 22, 2022
@aidamag
Copy link
Contributor Author

aidamag commented Sep 23, 2022

Breaking change in the box component, looks like it wasn't working properly.

image

@aidamag aidamag linked an issue Sep 23, 2022 that may be closed by this pull request
@aidamag aidamag removed their assignment Sep 23, 2022
@Jialecl Jialecl self-requested a review September 23, 2022 09:36
@Jialecl Jialecl self-assigned this Sep 23, 2022
@Jialecl
Copy link
Collaborator

Jialecl commented Sep 23, 2022

Should we consider wrapping or ellipsis for the dropdown, the tag, the button and the slider?

When the content is really large they can affect the width of the container or the window, while other components jump to the next line or have ellipsis.

@aidamag
Copy link
Contributor Author

aidamag commented Sep 23, 2022

Opened discussion about its behaviour: Behavior for components with fitContent

@Jialecl Jialecl merged commit 61a8ced into master Oct 3, 2022
@Jialecl Jialecl deleted the fix-1277 branch October 3, 2022 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update component's size fitContent
2 participants