Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Radix UI Popover in Text Input #1305

Merged
merged 8 commits into from Oct 4, 2022
Merged

Implement Radix UI Popover in Text Input #1305

merged 8 commits into from Oct 4, 2022

Conversation

GomezIvann
Copy link
Collaborator

@GomezIvann GomezIvann commented Sep 23, 2022 •
edited

Summary:

  • Implement the Listbox from the Autosuggest functionality with the Popover of Radix.
  • Text Input component refactor for a better fit with the Popover.
  • Fixed version for Radix library (0.1.6). The latest release of this component (1.0.0) changes how the component works and it doesn't meet our needs, so we stay at the previous one.
  • Updated stories taking advantage of the component refactor. Testing the same but with fewer snapshots needed.

@GomezIvann GomezIvann self-assigned this Sep 23, 2022
@GomezIvann GomezIvann removed their assignment Sep 26, 2022
@GomezIvann GomezIvann linked an issue Sep 26, 2022 that may be closed by this pull request
Implement Text Input's autosuggest listbox with Radix Popover #1308
Closed
@GomezIvann GomezIvann self-assigned this Sep 26, 2022
@GomezIvann GomezIvann removed their assignment Sep 27, 2022
@marcialfps marcialfps self-assigned this Sep 29, 2022
@marcialfps marcialfps self-requested a review September 29, 2022 07:54
marcialfps
marcialfps requested changes Sep 30, 2022
View reviewed changes
lib/src/text-input/TextInput.test.js Show resolved Hide resolved
lib/src/text-input/TextInput.tsx Outdated Show resolved Hide resolved
lib/src/text-input/TextInput.stories.tsx Show resolved Hide resolved
@marcialfps marcialfps merged commit b0616f2 into master Oct 4, 2022
@marcialfps marcialfps deleted the gomezIvann-textInput-radix branch October 4, 2022 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcialfps marcialfps marcialfps approved these changes

Assignees

@marcialfps marcialfps

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement Text Input's autosuggest listbox with Radix Popover
2 participants
@GomezIvann @marcialfps