deprecating padding prop from accordion, box, card, dialog, footer & header #1335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GomezIvann
reviewed
Oct 18, 2022
GomezIvann
requested changes
Oct 19, 2022
website/screens/components/accordion/code/AccordionCodePage.tsx
Outdated
Show resolved
Hide resolved
GomezIvann
approved these changes
Oct 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
(Check off all the items before submitting)
/libdirectory./websiteas needed.Purpose
Update the documentation of affected components (accordion, box, card, dialog, footer & header) as having the prop padding deprecated. The positioning has been consulted with a designer previously.
Screenshots
Added alert to props sections of affected components.
Also, the deprecated tag has been added to the prop in the table.
Closes #1297