Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed file input value when used on forms #1362

Merged
merged 2 commits into from Nov 4, 2022
Merged

Fixed file input value when used on forms #1362

merged 2 commits into from Nov 4, 2022

Conversation

aidamag
Copy link
Contributor

@aidamag aidamag commented Nov 2, 2022

Checklist
(Check off all the items before submitting)

  • Build process is done without errors and all tests pass in /lib directory.
  • Self-reviewed the code prior to submitting.
  • Meets accessibility standards.
  • Added/updated documentation to /website as needed.
  • Added/updated tests as needed.

Description

  • Added name prop to hidden input, disabled, aria-hidden and readOnly as in the rest of the components that use hidden inputs.
  • Updated style to display: none as in the rest of the components.
  • Added test to check that the component is sending value when submitting with form.

Closes #1351

@aidamag aidamag marked this pull request as ready for review November 3, 2022 09:48
@GomezIvann GomezIvann self-requested a review November 3, 2022 09:53
@GomezIvann GomezIvann self-assigned this Nov 3, 2022
lib/src/file-input/FileInput.tsx Outdated Show resolved Hide resolved
@GomezIvann GomezIvann merged commit 65612cd into master Nov 4, 2022
@GomezIvann GomezIvann deleted the aida-fix-1351 branch November 4, 2022 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

File Input not submitting its value in forms
2 participants