Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some updates to Resultset table component #1428

Merged
merged 2 commits into from Dec 30, 2022

Conversation

GomezIvann
Copy link
Collaborator

@GomezIvann GomezIvann commented Dec 28, 2022

Checklist
(Check off all the items before submitting)

  • Build process is done without errors and all tests pass in the /lib directory.
  • Self-reviewed the code before submitting.
  • Meets accessibility standards.
  • Added/updated documentation to /website as needed.
  • Added/updated tests as needed.

Description
Some improvements to the Resultset Table:

  • The Table now extends its width to the maximum available (100%), just like our regular Table, regardless of its container display.
  • The gap between the sorting icons and a header title is now 8px, as it stands in the documentation. Until now, that wasn't happening.
  • Removing unnecessary styles from the component and useless containers, the component now is more simple.
  • New visual tests.
  • Minor code refactors and new accessibility features (aria-sort and roles were included).

Screenshots

image

Code:

    <ExampleContainer>
      <Title title="Flex" theme="light" level={4} />
      <DxcFlex>
        <DxcResultsetTable columns={columnsSortable} rows={rowsSortable} />
      </DxcFlex>
    </ExampleContainer>

Closes #1425

@GomezIvann GomezIvann marked this pull request as ready for review December 29, 2022 09:01
@raquelarrojo raquelarrojo self-requested a review December 30, 2022 08:15
@raquelarrojo raquelarrojo self-assigned this Dec 30, 2022
@raquelarrojo raquelarrojo merged commit ec06b53 into master Dec 30, 2022
@raquelarrojo raquelarrojo deleted the gomezivann-resultset-fix branch December 30, 2022 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resultset Table not always occupies the 100% of its container
2 participants