Date year focus & two digit year format fix #1439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aidamag
reviewed
Jan 24, 2023
GomezIvann
requested changes
Jan 24, 2023
GomezIvann
requested changes
Jan 24, 2023
aidamag
reviewed
Jan 24, 2023
GomezIvann
requested changes
Jan 26, 2023
GomezIvann
requested changes
Jan 26, 2023
GomezIvann
requested changes
Jan 27, 2023
GomezIvann
reviewed
Jan 30, 2023
There was a problem hiding this comment.
Some comments:
- Counting each component of the Date Input, we currently have 5 icons. Maybe we can create an Icons.tsx file as in other components and export them from there.
- Why do both
leftCaretandrightCarethavearia-hiddenset totrue? - Remove the unused import from Calendar.tsx.
GomezIvann
approved these changes
Jan 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
(Check off all the items before submitting)
/libdirectory./websiteas needed.Purpose
Fixed some bugs:
And added some tests.
Description
Added a third party library to mock the "today value" in the tests.
Added visual tests and a new test for the new behavior related to the two-digit year format.
The two-digit year format behavior works like this:
The first time a valid year is entered it will remember the value.
If we change the value of the year in the input it will add the first two digits of the year based on the last valid date year.
Closes #1435