Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing unnecessary z-index or creating stacking contexts #1447

Merged
merged 3 commits into from Jan 20, 2023

Conversation

Jialecl
Copy link
Collaborator

@Jialecl Jialecl commented Jan 19, 2023

Checklist
(Check off all the items before submitting)

  • Build process is done without errors and all tests pass in /lib directory.
  • Self-reviewed the code prior to submitting.
  • Meets accessibility standards.
  • Added/updated documentation to /website as needed.
  • Added/updated tests as needed.

Purpose
Remove unnecessary z-index > 0 from components

Description
For some components, the z-index set to >0 was unnecessary; in others, a stacking context is created to avoid any weird interaction with other components.

**Closes #1423 **

@Jialecl Jialecl marked this pull request as ready for review January 19, 2023 14:21
@aidamag aidamag self-assigned this Jan 19, 2023
@aidamag
Copy link
Contributor

aidamag commented Jan 20, 2023

Perfect!

@aidamag aidamag merged commit 4dc980c into master Jan 20, 2023
@aidamag aidamag deleted the jialecl-zIndex branch January 20, 2023 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

z-index problems in Halstack components
2 participants