Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select specification updates & more #1450

Merged
merged 6 commits into from Feb 2, 2023
Merged

Conversation

GomezIvann
Copy link
Collaborator

@GomezIvann GomezIvann commented Jan 27, 2023

Checklist

  • Build process is done without errors and all tests pass in the /lib directory.
  • Self-reviewed the code before submitting.
  • Meets accessibility standards.
  • Added/updated documentation to /website as needed.
  • Added/updated tests as needed.

Description

  • Update the specifications page of the Select component to match the new options icon sizing.
  • Minor code refactors:
    • Now the component uses the Resize Observer API for the width of the Listbox.
    • ThemeProvider is only used in the parent component (Select.tsx). Sub-components don't have it anymore to avoid additional renders.
    • Adjustments based on the above changes.

@GomezIvann GomezIvann marked this pull request as ready for review January 27, 2023 13:24
@jsuarezgonz jsuarezgonz self-requested a review February 1, 2023 13:46
@jsuarezgonz jsuarezgonz self-assigned this Feb 2, 2023
@jsuarezgonz jsuarezgonz merged commit a062293 into master Feb 2, 2023
@jsuarezgonz jsuarezgonz deleted the gomezivann-select-updates branch February 2, 2023 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants