New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding HalstackProvider documentation #1453
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The extension of the example files is not correct since we are not using actual JSX code inside of them. For example, advancedTheme.tsx
should be instead advancedTheme.ts
website/screens/utilities/halstackProvider/HalstackProviderPage.tsx
Outdated
Show resolved
Hide resolved
website/screens/utilities/halstackProvider/HalstackProviderPage.tsx
Outdated
Show resolved
Hide resolved
website/screens/utilities/halstackProvider/HalstackProviderPage.tsx
Outdated
Show resolved
Hide resolved
website/screens/utilities/halstackProvider/HalstackProviderPage.tsx
Outdated
Show resolved
Hide resolved
website/screens/utilities/halstackProvider/HalstackProviderPage.tsx
Outdated
Show resolved
Hide resolved
website/screens/utilities/halstackProvider/examples/customTranslations.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These files are missing from changing their extension (correct me if I'm wrong but any of them has JSX code):
- bloomTheme.tsx
- customTranslations.tsx
- defaultAdvancedTheme.tsx
- opinionatedTheme.tsx
Checklist
(Check off all the items before submitting)
/lib
directory./website
as needed.Description
A new 'Utilities' section is created with the HalstackProvider documentation. This documentation includes examples of how to use the HalstackProvider with the opinionated theme, the advanced theme, and an example of label translation.
Themes documentation is modified to explain in a more detailed way the different theming strategies we have.