Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating documentation and tokens for datePicker #1456

Merged
merged 7 commits into from Feb 8, 2023

Conversation

Jialecl
Copy link
Collaborator

@Jialecl Jialecl commented Feb 3, 2023

Checklist
(Check off all the items before submitting)

  • Build process is done without errors and all tests pass in /lib directory.
  • Self-reviewed the code prior to submitting.
  • Meets accessibility standards.
  • Added/updated documentation to /website as needed.
  • Added/updated tests as needed.

Purpose
Added advanced tokens and updated specs for the dateInput.
Also added localization documentation for the datePicker.

Screenshots
image
date_popup_specs
This image has been updated to show the caret correctly.
image

@Jialecl Jialecl marked this pull request as ready for review February 6, 2023 07:47
@Jialecl
Copy link
Collaborator Author

Jialecl commented Feb 6, 2023

It seems that the font family was not applied correctly to the years in the year picker thus the chage in ui tests.

@raquelarrojo raquelarrojo self-assigned this Feb 6, 2023
@raquelarrojo raquelarrojo self-requested a review February 6, 2023 07:49
Copy link
Collaborator

@raquelarrojo raquelarrojo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update advanced.theme.json and advanced.schema.json with new date input tokens.

lib/src/date-input/DatePicker.tsx Show resolved Hide resolved
lib/src/date-input/YearPicker.tsx Show resolved Hide resolved
lib/src/HalstackContext.tsx Show resolved Hide resolved
lib/src/HalstackContext.tsx Outdated Show resolved Hide resolved
lib/src/HalstackContext.tsx Show resolved Hide resolved
@raquelarrojo raquelarrojo self-requested a review February 8, 2023 08:56
@raquelarrojo raquelarrojo merged commit 64fdce7 into master Feb 8, 2023
@raquelarrojo raquelarrojo deleted the jialecl-calendarDocumentation branch February 8, 2023 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants