Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/oc 13122 - NavTabs Design Tokens #1477

Merged
merged 17 commits into from Feb 21, 2023
Merged

Conversation

kukoc
Copy link
Contributor

@kukoc kukoc commented Feb 16, 2023

Checklist
(Check off all the items before submitting)

  • Build process is done without errors and all tests pass in /lib directory.
  • Self-reviewed the code prior to submitting.
  • Meets accessibility standards.
  • Added/updated documentation to /website as needed. -> Specs about NavTab tokens will be added in a separate Jira
  • Added/updated tests as needed. -> Not needed

Purpose
Adding Design Tokens to the NavTabs Component implementation

@raquelarrojo raquelarrojo self-requested a review February 16, 2023 11:23
@raquelarrojo raquelarrojo self-assigned this Feb 16, 2023
Copy link
Collaborator

@raquelarrojo raquelarrojo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would also add tokens for icon in NavTabs component, as in Tabs component.
Now, there are no styles applied to the icon.

Notification badge should be aligned in row with the label.
Now:
image

Before:
image

lib/src/common/variables.js Show resolved Hide resolved
lib/src/common/variables.js Show resolved Hide resolved
lib/src/common/variables.js Outdated Show resolved Hide resolved
lib/src/common/variables.js Show resolved Hide resolved
lib/src/common/variables.js Show resolved Hide resolved
lib/src/tabs-nav/Tab.tsx Show resolved Hide resolved
lib/src/tabs-nav/Tab.tsx Show resolved Hide resolved
lib/src/tabs-nav/Tab.tsx Outdated Show resolved Hide resolved
@kukoc kukoc changed the title Feature/oc 13122 Feature/oc 13122 - NavTabs Design Tokens Feb 16, 2023
lib/src/common/variables.js Show resolved Hide resolved
lib/src/tabs-nav/Tab.tsx Outdated Show resolved Hide resolved
@raquelarrojo raquelarrojo self-requested a review February 21, 2023 13:55
@raquelarrojo raquelarrojo merged commit 5b43b04 into master Feb 21, 2023
@raquelarrojo raquelarrojo deleted the feature/OC-13122 branch February 21, 2023 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants