Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating nav tabs broken links #1484

Merged
merged 1 commit into from Feb 17, 2023
Merged

Updating nav tabs broken links #1484

merged 1 commit into from Feb 17, 2023

Conversation

Jialecl
Copy link
Collaborator

@Jialecl Jialecl commented Feb 17, 2023

Checklist
(Check off all the items before submitting)

  • Build process is done without errors and all tests pass in /lib directory.
  • Self-reviewed the code prior to submitting.
  • Meets accessibility standards.
  • Added/updated documentation to /website as needed.
  • Added/updated tests as needed.

Purpose
Updating broken links in nav tabs documentation regarding react router documentation.

Description
The links are related to the examples that react-router provides (they moved the examples to a GitHub repository instead of hosting the examples in the documentation page) and the usage of the usehref hook.

**Closes #1452 **

@Jialecl Jialecl marked this pull request as ready for review February 17, 2023 11:31
@jsuarezgonz jsuarezgonz merged commit a6a69fa into master Feb 17, 2023
@jsuarezgonz jsuarezgonz deleted the jcheng-navTabsLinks branch February 17, 2023 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Link not found in website
2 participants