Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added nav tabs previews to theme generator #1503

Merged
merged 4 commits into from Mar 1, 2023

Conversation

raquelarrojo
Copy link
Collaborator

Checklist
(Check off all the items before submitting)

  • Build process is done without errors and all tests pass in /lib directory.
  • Self-reviewed the code prior to submitting.
  • Meets accessibility standards.
  • Added/updated documentation to /website as needed.
  • Added/updated tests as needed.

Purpose
Nav tabs previews are left in theme generator, so its opinionated theme cannot be changed.

Description
Nav tabs previews added to theme generator.

Screenshots
image

Closes #1502

@raquelarrojo raquelarrojo marked this pull request as ready for review March 1, 2023 11:52
@Jialecl Jialecl self-requested a review March 1, 2023 13:01
@Jialecl Jialecl self-assigned this Mar 1, 2023
@Jialecl
Copy link
Collaborator

Jialecl commented Mar 1, 2023

The token unselectedBackgroundColor is not been used.

image

@raquelarrojo
Copy link
Collaborator Author

The token unselectedBackgroundColor is not been used.

image

Fixed! @Jialecl

image

Fix will not be visible in theme generator until cdk version is updated in website.

@Jialecl Jialecl merged commit ad31801 into master Mar 1, 2023
@Jialecl Jialecl deleted the rarrojolopez-navtabs-themeGenerator branch March 1, 2023 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nav tabs previews are missing in theme generator
2 participants