New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dialog review #1504
Dialog review #1504
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are some of the strange behaviours I have found out for now:
If there is an element with a tabIndex > 0
the focus can leave the dialog.
When using the shift tab from the first element it seems to need an extra step to focus on the last element.
The second case is already fixed. In regards to the first one, I couldn't reproduce it since in my code is working fine, could you please paste yours in a comment? |
I just simply added a |
I saw the problem. When we change the |
One more thing I noticed is that if the first element has |
That's because that's not how You can take a look at other implementations to check this: |
Checklist
/lib
directory./website
as needed.Description
Summary:
padding-top
removed (Dialog Box - padding top #1446). Now, when displayed, the decision of how to avoid the clear action button relies on the user.800px
to696px
.Escape
key. When the dialog didn't have any component to bubble theonkeydown
event, the key didn't close the modal box. For example, a Dialog with only text.fontFamily
,fontSize
andfontWeight
.Closes #1446 #1470 #1485 #1496