Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chip spacing fix #1609

Merged
merged 6 commits into from Jun 7, 2023
Merged

Chip spacing fix #1609

merged 6 commits into from Jun 7, 2023

Conversation

GomezIvann
Copy link
Collaborator

@GomezIvann GomezIvann commented Jun 2, 2023 •
edited

Checklist
(Check off all the items before submitting)

  • Build process is done without errors and all tests pass in the /lib directory.
  • Self-reviewed the code before submitting.
  • Meets accessibility standards.
  • Added/updated documentation to /website as needed.
  • Added/updated tests as needed.

Description
Summary:

  • Fixes a spacing issue in the container of the Chip component.
  • Some accessibility improvements to the component and small fixes to how interactive icons look.
  • Code page updated with better explanations and examples.

Screenshots

image

Closes #1608

@GomezIvann GomezIvann marked this pull request as ready for review June 2, 2023 13:15
@Jialecl Jialecl self-requested a review June 5, 2023 08:55
@Jialecl Jialecl self-assigned this Jun 5, 2023
@Jialecl Jialecl merged commit 293a019 into master Jun 7, 2023
4 checks passed
@Jialecl Jialecl deleted the gomezivann/fix-chip branch June 7, 2023 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jialecl Jialecl Jialecl approved these changes

Assignees

@Jialecl Jialecl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Chip component has an extra right space
2 participants
@GomezIvann @Jialecl