Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ADA critical issues fixes #1644

Merged
merged 6 commits into from Jul 13, 2023
Merged

ADA critical issues fixes #1644

merged 6 commits into from Jul 13, 2023

Conversation

GomezIvann
Copy link
Collaborator

@GomezIvann GomezIvann commented Jul 4, 2023 •
edited

Checklist

  • Build process is done without errors and all tests pass in the /lib directory.
  • Self-reviewed the code before submitting.
  • Meets accessibility standards.
  • Added/updated documentation to /website as needed.
  • Added/updated tests as needed.

Description
Trying to fix ADA compliance critical issues:

  • Include the lang attribute in the <html> element.
  • Add title to heading links.

I've also updated the halstack-react package version.

Closes #1643

@GomezIvann GomezIvann changed the title Gomezivann ada fixes ADA critical issues fixes Jul 4, 2023
@GomezIvann GomezIvann marked this pull request as ready for review July 4, 2023 13:03
@GomezIvann GomezIvann marked this pull request as draft July 4, 2023 13:16
@GomezIvann GomezIvann marked this pull request as ready for review July 5, 2023 10:21
@GomezIvann GomezIvann mentioned this pull request Jul 5, 2023
Closed
@jsuarezgonz jsuarezgonz self-assigned this Jul 10, 2023
@jsuarezgonz jsuarezgonz merged commit 4c241e0 into master Jul 13, 2023
1 check passed
@jsuarezgonz jsuarezgonz deleted the gomezivann-ada-fixes branch July 13, 2023 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsuarezgonz jsuarezgonz jsuarezgonz approved these changes

Assignees

@jsuarezgonz jsuarezgonz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Solve ADA critical issues
2 participants
@GomezIvann @jsuarezgonz