Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding title attribute to Footer social links #1646

Merged
merged 7 commits into from Jul 11, 2023
Merged

Adding title attribute to Footer social links #1646

merged 7 commits into from Jul 11, 2023

Conversation

GomezIvann
Copy link
Collaborator

@GomezIvann GomezIvann commented Jul 5, 2023 •
edited

Checklist

  • Build process is done without errors and all tests pass in the /lib directory.
  • Self-reviewed the code before submitting.
  • Meets accessibility standards.
  • Added/updated documentation to /website as needed.
  • Added/updated tests as needed.

Description
Summary:

  • Added attribute title to the Footer component inside each object of the socialLinks prop.
  • Refactor of the Footer component (code four years old).

Closes #1645

@GomezIvann GomezIvann changed the title Gomezivann title Addind title attribute to Footer social links Jul 5, 2023
@GomezIvann GomezIvann changed the title Addind title attribute to Footer social links Adding title attribute to Footer social links Jul 5, 2023
@GomezIvann GomezIvann marked this pull request as ready for review July 6, 2023 07:34
@Jialecl Jialecl self-requested a review July 10, 2023 09:23
@Jialecl Jialecl self-assigned this Jul 10, 2023
@Jialecl Jialecl merged commit 0276e5a into master Jul 11, 2023
4 checks passed
@Jialecl Jialecl deleted the gomezivann-title branch July 11, 2023 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jialecl Jialecl Jialecl approved these changes

Assignees

@Jialecl Jialecl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a title prop to Footer social links
2 participants
@GomezIvann @Jialecl