Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add readOnly prop to the Text Input and Date Input #1688

Merged
merged 3 commits into from Oct 2, 2023
Merged

Add readOnly prop to the Text Input and Date Input #1688

merged 3 commits into from Oct 2, 2023

Conversation

GomezIvann
Copy link
Collaborator

@GomezIvann GomezIvann commented Sep 26, 2023 •
edited

Checklist

  • Build process is done without errors. All tests pass in the /lib directory.
  • Self-reviewed the code before submitting.
  • Meets accessibility standards.
  • Added/updated documentation to /website as needed.
  • Added/updated tests as needed.

Description
The new read-only variant of the Text Input and the Date Input.

Closes #1687 and #1689

@GomezIvann GomezIvann changed the title Add readOnly prop to the Text Input Add readOnly prop to the Text Input and Date Input Sep 26, 2023
@GomezIvann GomezIvann linked an issue Sep 26, 2023 that may be closed by this pull request
Add the readOnly prop to the Date Input component #1689
Closed
@GomezIvann GomezIvann marked this pull request as ready for review September 27, 2023 12:43
@Jialecl Jialecl self-requested a review September 28, 2023 15:11
@Jialecl Jialecl self-assigned this Sep 28, 2023
@Jialecl Jialecl merged commit 2bca710 into master Oct 2, 2023
4 checks passed
@Jialecl Jialecl deleted the gomezivann/textInput-readOnly branch October 2, 2023 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jialecl Jialecl Jialecl approved these changes

Assignees

@Jialecl Jialecl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add the readOnly prop to the Date Input component Add the readOnly prop to the Text Input component
2 participants
@GomezIvann @Jialecl