Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add readOnly prop to Checkbox #1693

Merged
merged 4 commits into from Oct 2, 2023
Merged

Conversation

GomezIvann
Copy link
Collaborator

@GomezIvann GomezIvann commented Sep 27, 2023

Checklist

  • Build process is done without errors. All tests pass in the /lib directory.
  • Self-reviewed the code before submitting.
  • Meets accessibility standards.
  • Added/updated documentation to /website as needed.
  • Added/updated tests as needed.

Description
The new read-only variant of the Checkbox.

Closes #1692

@GomezIvann GomezIvann marked this pull request as ready for review September 27, 2023 12:42
@raquelarrojo raquelarrojo self-requested a review October 2, 2023 07:24
@raquelarrojo raquelarrojo self-assigned this Oct 2, 2023
@raquelarrojo
Copy link
Collaborator

Could you please do this change also in the tokens we have in the files defaultAdvancedTheme.ts, advanced-theme.json and advanced.schema.json?

@raquelarrojo
Copy link
Collaborator

Could you please do this change also in the tokens we have in the files defaultAdvancedTheme.ts, advanced-theme.json and advanced.schema.json?
This will be done when readOnly is added to all components.

@raquelarrojo raquelarrojo merged commit 752ca0a into master Oct 2, 2023
4 checks passed
@raquelarrojo raquelarrojo deleted the gomezivann/readonly-checkbox branch October 2, 2023 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add the readOnly prop to the Checkbox component
2 participants