Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add readOnly prop to Number Input component #1696

Merged
merged 2 commits into from Oct 3, 2023
Merged

Add readOnly prop to Number Input component #1696

merged 2 commits into from Oct 3, 2023

Conversation

GomezIvann
Copy link
Collaborator

@GomezIvann GomezIvann commented Oct 2, 2023 •
edited

Checklist

  • Build process is done without errors. All tests pass in the /lib directory.
  • Self-reviewed the code before submitting.
  • Meets accessibility standards.
  • Added/updated documentation to /website as needed.
  • Added/updated tests as needed.

Description
The new read-only variant of the Number Input.

Closes #1697

@GomezIvann GomezIvann marked this pull request as ready for review October 2, 2023 14:49
@Jialecl Jialecl self-requested a review October 2, 2023 15:15
@Jialecl Jialecl self-assigned this Oct 2, 2023
@Jialecl Jialecl merged commit c67081d into master Oct 3, 2023
4 checks passed
@Jialecl Jialecl deleted the gomezivann/numberInput-readonly branch October 3, 2023 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jialecl Jialecl Jialecl approved these changes

Assignees

@Jialecl Jialecl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add the readOnly prop to the Number Input component
2 participants
@GomezIvann @Jialecl