Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Props table design #1715

Merged
merged 38 commits into from Oct 30, 2023
Merged

New Props table design #1715

merged 38 commits into from Oct 30, 2023

Conversation

GomezIvann
Copy link
Collaborator

@GomezIvann GomezIvann commented Oct 18, 2023

Checklist

  • Build process is done without errors. All tests pass in the /lib directory.
  • Self-reviewed the code before submitting.
  • Meets accessibility standards.
  • Added/updated documentation to /website as needed.
  • Added/updated tests as needed.

Description
New Props table design for every Halstack component. New tag for required props.

Screenshots
image

Closes #1672

GomezIvann and others added 28 commits October 10, 2023 09:32
@GomezIvann GomezIvann marked this pull request as ready for review October 20, 2023 07:56
@GomezIvann
Copy link
Collaborator Author

GomezIvann commented Oct 20, 2023

To keep track of the components under review, here is a list of each one of them:

  • Accordion
  • Alert
  • Application Layout
  • Bleed
  • Box
  • Bulleted List
  • Button (Raquel)
  • Card (Raquel)
  • Checkbox (Raquel)
  • Chip (Raquel)
  • Date Input (Raquel)
  • Dialog (Raquel)
  • Dropdown (Raquel)
  • File Input (Raquel)
  • Flex
  • Footer
  • Grid (Jiale)
  • Header (Raquel)
  • Heading (Jiale)
  • Image
  • Inset
  • Link (Raquel)
  • Nav Tabs (Raquel)
  • Number Input
  • Paginator(Jiale)
  • Paragraph
  • Password Input
  • Progress Bar (Raquel)
  • Quick Nav (Raquel)
  • Radio Group (Raquel)
  • Resultset Table
  • Select
  • Sidenav (Raquel)
  • Slider (Raquel)
  • Spinner (Raquel)
  • Switch (Raquel)
  • Table (Raquel)
  • Tabs (Raquel)
  • Tag
  • Text Input
  • Textarea
  • Toggle Group
  • Typography
  • Wizard

Copy link
Collaborator

@jsuarezgonz jsuarezgonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<Code> tag is missing in some of the props descriptions:

  • Alert-> name onClose in the prop mode description.
  • ApplicationLayout-> reference to DxcApplicationLayout.Main in the prop children.
  • Date-> prop format references to onBlur and onChange.
  • Link-> reference to prop icon in iconPosition.
  • NumberInput-> reference to onBlur and onChange in min and max props.
  • PasswordInput-> reference to onBlur and onChange in props pattern, minLength and maxLength.
  • RadioGroup-> reference to prop options in prop stacking.

@raquelarrojo raquelarrojo merged commit b7a7d72 into master Oct 30, 2023
4 checks passed
@raquelarrojo raquelarrojo deleted the gomezivann/new-props-table branch October 30, 2023 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the component Props table
4 participants