New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Props table design #1715
Merged
Merged
New Props table design #1715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…echnology/halstack-react into gomezivann/new-props-table
To keep track of the components under review, here is a list of each one of them:
|
jsuarezgonz
reviewed
Oct 20, 2023
jsuarezgonz
reviewed
Oct 20, 2023
raquelarrojo
requested changes
Oct 23, 2023
raquelarrojo
requested changes
Oct 23, 2023
raquelarrojo
requested changes
Oct 24, 2023
Jialecl
reviewed
Oct 24, 2023
jsuarezgonz
requested changes
Oct 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<Code>
tag is missing in some of the props descriptions:
Alert
-> nameonClose
in the propmode
description.ApplicationLayout
-> reference toDxcApplicationLayout.Main
in the propchildren
.Date
-> propformat
references toonBlur
andonChange
.Link
-> reference to propicon
iniconPosition
.NumberInput
-> reference toonBlur
andonChange
in minmax
props.PasswordInput
-> reference toonBlur
andonChange
in propspattern
,minLength
andmaxLength
.RadioGroup
-> reference to propoptions
in propstacking
.
raquelarrojo
requested changes
Oct 27, 2023
Jialecl
reviewed
Oct 30, 2023
website/screens/components/paginator/code/PaginatorCodePage.tsx
Outdated
Show resolved
Hide resolved
raquelarrojo
approved these changes
Oct 30, 2023
jsuarezgonz
approved these changes
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
/lib
directory./website
as needed.Description
New Props table design for every Halstack component. New tag for required props.
Screenshots
Closes #1672