Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Container component implementation #1748

Merged
merged 8 commits into from Jan 10, 2024
Merged

Conversation

GomezIvann
Copy link
Collaborator

@GomezIvann GomezIvann commented Dec 18, 2023

Checklist

  • Build process is done without errors. All tests pass in the /lib directory.
  • Self-reviewed the code before submitting.
  • Meets accessibility standards.
  • Added/updated documentation to /website as needed.
  • Added/updated tests as needed.

Description
Implementation of the new component of Halstack Design System: Container.

Represents The Box Model inside the Halstack Desing System. Is a general-purpose container that allows for controlled use of our design tokens. Being generic in nature can be "over-used", so it’s important to consider situations where more specific and expressive primitives could be used.

Closes #1213

@GomezIvann GomezIvann added the new component New component requested label Dec 18, 2023
@Jialecl Jialecl self-requested a review December 26, 2023 13:22
@Jialecl Jialecl merged commit 89972a4 into master Jan 10, 2024
4 checks passed
@Jialecl Jialecl deleted the gomezivann/container-component branch January 10, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new component New component requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Box primitive
2 participants