Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Font-bold token was documented in the Spinner specs section #1759

Merged
merged 1 commit into from Jan 15, 2024

Conversation

lcordobapuerto
Copy link
Collaborator

@lcordobapuerto lcordobapuerto commented Jan 15, 2024

Checklist
(Check off all the items before submitting)

  • Build process is done without errors. All tests pass in the /lib directory.
  • Self-reviewed the code before submitting.
  • Meets accessibility standards.
  • Added/updated documentation to /website as needed.
  • Added/updated tests as needed.

Purpose
To change the value of the token assigned to spinner component.

Description
In the Specs of the Spinner component, it is described that the font-weight of the percentage is 600, which is not correct, as it is 700. The token displayed for that font-weight is correct once we change that value, as font-bold sets font weight as bold (700).

Screenshots

Spinner typography specs halstack-typography-tokens

@GomezIvann GomezIvann self-requested a review January 15, 2024 11:50
@GomezIvann GomezIvann self-assigned this Jan 15, 2024
@GomezIvann
Copy link
Collaborator

Great job Lara! 🚀

@GomezIvann GomezIvann merged commit f2972a2 into master Jan 15, 2024
1 check passed
@GomezIvann GomezIvann deleted the lcordobapuerto/spinner-specs branch January 15, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants