Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bug with checkboxes in resultset table #1773

Merged
merged 6 commits into from Jan 26, 2024

Conversation

Mil4n0r
Copy link
Collaborator

@Mil4n0r Mil4n0r commented Jan 23, 2024

Checklist

  • Build process is done without errors. All tests pass in the /lib directory.
  • Self-reviewed the code before submitting.
  • Meets accessibility standards.
  • Added/updated documentation to /website as needed.
  • Added/updated tests as needed.

Description
Fixes the bug that occurred when trying to change pages after modifying a Checkbox within a Resultset Table component.

Additional context
It not also applied to Checkbox but to any updatable component (TextArea, etc.)

The problem happened due to the key value not being calculated properly when iterating through the filteredResultSet (as it was not taking into account the current page index)

Closes #1752

@Mil4n0r Mil4n0r marked this pull request as ready for review January 23, 2024 16:23
@Jialecl Jialecl self-requested a review January 26, 2024 09:12
@Jialecl Jialecl self-assigned this Jan 26, 2024
@Mil4n0r Mil4n0r requested a review from Jialecl January 26, 2024 12:20
@Jialecl Jialecl merged commit c9c1158 into master Jan 26, 2024
4 checks passed
@Jialecl Jialecl deleted the Mil4n0r/resultset_table_checkbox-fix branch January 26, 2024 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Checkbox not working properly with Resultset Table
2 participants