Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added small footer variant #1793

Merged
merged 18 commits into from Feb 13, 2024
Merged

Added small footer variant #1793

merged 18 commits into from Feb 13, 2024

Conversation

Mil4n0r
Copy link
Collaborator

@Mil4n0r Mil4n0r commented Jan 31, 2024

Checklist

  • Build process is done without errors. All tests pass in the /lib directory.
  • Self-reviewed the code before submitting.
  • Meets accessibility standards.
  • Added/updated documentation to /website as needed.
  • Added/updated tests as needed.

Description
A smaller version of the footer component is required.
The solution will need to only display the logo and a content defined by the user, everything displayed in the same row.

Screenshots
image

Closes #1792

@Mil4n0r Mil4n0r marked this pull request as ready for review February 1, 2024 14:37
lib/src/footer/Footer.tsx Outdated Show resolved Hide resolved
@Mil4n0r Mil4n0r marked this pull request as draft February 2, 2024 07:33
@Mil4n0r
Copy link
Collaborator Author

Mil4n0r commented Feb 2, 2024

Converted to draft in order to discuss the naming of the variant prop.

EDIT: Updated prop to be called 'mode'

@Mil4n0r Mil4n0r marked this pull request as ready for review February 2, 2024 11:25
@raquelarrojo raquelarrojo self-requested a review February 6, 2024 07:48
@raquelarrojo raquelarrojo self-assigned this Feb 6, 2024
lib/src/footer/Footer.tsx Show resolved Hide resolved
lib/src/footer/Footer.tsx Show resolved Hide resolved
lib/src/footer/Footer.tsx Show resolved Hide resolved
lib/src/footer/Footer.tsx Show resolved Hide resolved
website/screens/components/footer/code/FooterCodePage.tsx Outdated Show resolved Hide resolved
lib/src/footer/Footer.stories.tsx Outdated Show resolved Hide resolved
lib/src/footer/types.ts Outdated Show resolved Hide resolved
@Mil4n0r Mil4n0r marked this pull request as draft February 8, 2024 13:54
@Mil4n0r Mil4n0r marked this pull request as ready for review February 8, 2024 14:40
@raquelarrojo raquelarrojo merged commit 8ded8ca into master Feb 13, 2024
4 checks passed
@raquelarrojo raquelarrojo deleted the Mil4n0r/small-footer branch February 13, 2024 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement a smaller version of the footer component
2 participants