Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added 100% width underline to NavTab #1796

Merged
merged 3 commits into from Feb 7, 2024
Merged

Conversation

Mil4n0r
Copy link
Collaborator

@Mil4n0r Mil4n0r commented Feb 1, 2024

Checklist

  • Build process is done without errors. All tests pass in the /lib directory.
  • Self-reviewed the code before submitting.
  • Meets accessibility standards.
  • Added/updated documentation to /website as needed.
  • Added/updated tests as needed.

Description
It has been decided that it is more appropiate for NavTabs component to always fill all the available space, that prevents ourselves from using "tricks" in order to achieve that.

Screenshots
image

Closes #1525

@Mil4n0r Mil4n0r marked this pull request as ready for review February 1, 2024 10:17
@GomezIvann GomezIvann self-requested a review February 2, 2024 08:51
@GomezIvann GomezIvann self-assigned this Feb 2, 2024
@GomezIvann GomezIvann merged commit 65c8e88 into master Feb 7, 2024
4 checks passed
@GomezIvann GomezIvann deleted the Mil4n0r/navtab_width-fix branch February 7, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nav Tabs divider not occupying 100% width available
2 participants