Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed popups not working inside Dialog #1822

Merged
merged 1 commit into from Feb 14, 2024
Merged

Fixed popups not working inside Dialog #1822

merged 1 commit into from Feb 14, 2024

Conversation

Mil4n0r
Copy link
Collaborator

@Mil4n0r Mil4n0r commented Feb 14, 2024

Checklist

  • Build process is done without errors. All tests pass in the /lib directory.
  • Self-reviewed the code before submitting.
  • Meets accessibility standards.
  • Added/updated documentation to /website as needed.
  • Added/updated tests as needed.

Description
Popups inside dialog were not being displayed correctly. This has been fixed ensuring that Popups are being properly identified inside the DOM.

(Related to PR #1817)

Closes #1809

@Mil4n0r Mil4n0r requested a review from Jialecl February 14, 2024 14:15
@Jialecl Jialecl self-assigned this Feb 14, 2024
@Jialecl Jialecl merged commit 92fa0e1 into master Feb 14, 2024
4 checks passed
@Jialecl Jialecl deleted the Mil4n0r/dialog_popup-fix branch February 14, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jialecl Jialecl Jialecl approved these changes

Assignees

@Jialecl Jialecl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Some components not working inside Dialog
2 participants
@Mil4n0r @Jialecl