Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Breadcrumbs component #1828

Merged
merged 24 commits into from Mar 22, 2024
Merged

New Breadcrumbs component #1828

merged 24 commits into from Mar 22, 2024

Conversation

GomezIvann
Copy link
Collaborator

@GomezIvann GomezIvann commented Feb 16, 2024

Checklist

  • The build process is done without errors. All tests pass in the /lib directory.
  • Self-reviewed the code before submitting.
  • Meets accessibility standards.
  • Added/updated documentation to /website as needed.
  • Added/updated tests as needed.

Description
The breadcrumbs component represents a list of links showing the location of the current page in the navigational hierarchy.

Requirements
To be able to implement this component, some extra requirements were needed:

  • The @types/jest library was added so we can start to name test files with the extension .tsx, which is more correct.
  • Updated spacing values in the design system to match the current specifications.

Design
UXPin Preview

Screenshot

image

image

Closes #1488

@GomezIvann GomezIvann changed the title New Breadcrumbs component **[Alpha]** New Breadcrumbs component Feb 16, 2024
@GomezIvann GomezIvann changed the title **[Alpha]** New Breadcrumbs component [Alpha] New Breadcrumbs component Feb 16, 2024
@GomezIvann GomezIvann changed the title [Alpha] New Breadcrumbs component New Breadcrumbs component Mar 14, 2024
@GomezIvann GomezIvann marked this pull request as ready for review March 18, 2024 16:23
@Jialecl Jialecl self-requested a review March 19, 2024 09:39
@Jialecl Jialecl self-assigned this Mar 19, 2024
lib/src/breadcrumbs/dropdownTheme.ts Show resolved Hide resolved
lib/src/common/variables.ts Outdated Show resolved Hide resolved
@Mil4n0r
Copy link
Collaborator

Mil4n0r commented Mar 20, 2024

Currently, accessibility tests are not passing due to the same reason they weren't initally passing for Header and Footer, in this case the nav tag is being repeated in the same page.

We should create a disabledRules.js file inside lib/test/accessibility/specific/breadcrumbs similar to the one existing in the header but with only the "landmark-unique" rule as exception.

It should be added to both the Story file and the Breadcrumbs.accessibility.test that should be created before merging this PR.

@Mil4n0r Mil4n0r self-requested a review March 20, 2024 12:36
@Mil4n0r Mil4n0r self-assigned this Mar 20, 2024
@GomezIvann GomezIvann requested a review from Jialecl March 20, 2024 16:18
lib/setupJestAxe.js Outdated Show resolved Hide resolved
lib/src/breadcrumbs/Breadcrumbs.tsx Outdated Show resolved Hide resolved
Jialecl
Jialecl previously approved these changes Mar 21, 2024
@Jialecl Jialecl self-requested a review March 21, 2024 15:51
Jialecl
Jialecl previously approved these changes Mar 22, 2024
@Jialecl Jialecl merged commit 71449a5 into master Mar 22, 2024
4 checks passed
@Jialecl Jialecl deleted the gomezivann/breadcrumbs branch March 22, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

margin values not following the guidelines
3 participants