Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Contextual Menu component #1850

Merged
merged 11 commits into from Mar 4, 2024
Merged

Conversation

GomezIvann
Copy link
Collaborator

@GomezIvann GomezIvann commented Feb 26, 2024

Checklist

  • The Build process is done without errors. All tests pass in the /lib directory.
  • Self-reviewed the code before submitting.
  • Meets accessibility standards.
  • Added/updated documentation to /website as needed.
  • Added/updated tests as needed.

Description
Implementation of the new component DxcContextualMenu. Based on Lara's Designs.

Component definition
This component is a collection of actions that modify in some way the current Page where it is been displayed. Don't confuse this component with the Sidenav, which is a navigational component at the Application level.

@GomezIvann GomezIvann marked this pull request as ready for review February 27, 2024 11:52
@GomezIvann GomezIvann added the new component New component requested label Feb 27, 2024
@Mil4n0r Mil4n0r self-requested a review February 28, 2024 07:32
lib/src/contextual-menu/MenuItem.tsx Outdated Show resolved Hide resolved
lib/src/contextual-menu/ContextualMenu.tsx Outdated Show resolved Hide resolved
lib/src/contextual-menu/ContextualMenu.tsx Outdated Show resolved Hide resolved
@Mil4n0r Mil4n0r self-assigned this Feb 28, 2024
@raquelarrojo raquelarrojo self-requested a review March 4, 2024 08:08
@raquelarrojo raquelarrojo merged commit 2289057 into master Mar 4, 2024
4 checks passed
@raquelarrojo raquelarrojo deleted the gomezivann/contextual-menu branch March 4, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new component New component requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants