New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding groups to the Contextual Menu #1892
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GomezIvann
changed the title
New Contextual Menu component
Adding groups to the Contextual Menu
Mar 14, 2024
kukoc
reviewed
Mar 15, 2024
kukoc
reviewed
Mar 15, 2024
kukoc
requested changes
Mar 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple of minor things that I believe should be changed
kukoc
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
/lib
directory./website
as needed.Description
In the previous weeks, we have been working on a new component, the
DxcContextualMenu
. During its development, a new need arose: adding groups to the component, which can contain single elements or other groups.To implement this new functionality we had to use a recursive algorithm to optimize the rendering of nested components up to N level. This had a few consequences for the component API:
defaultSelectedItemIndex
has been removed. The default selection employing an index became more complex with the inclusion of groups.DxcBadge
as the value of the prop with the same name.The design can be checked here.