-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added new logic for resultsetTable to manage sorting and adding/removing rows properly #1938
Conversation
…technology/halstack-react into Mil4n0r/resultsettable_checkbox-fix
Closed for now until the topic is discussed. |
Reopened, will remove it from Draft when I receive more feedback in the issue. |
…o Mil4n0r/resultsettable_checkbox-fix
…technology/halstack-react into Mil4n0r/resultsettable_checkbox-fix
…o Mil4n0r/resultsettable_checkbox-fix
The new problem shared by Alan is caused by the fact that we are currently using This would lead to 2 possible solutions:
|
…technology/halstack-react into Mil4n0r/resultsettable_checkbox-fix
I have added a new mechanism to generate keys prior to making the sorting. Generate an intermediate structure with separate ids and cells preventing us from having to change the I have done testing in local to ensure that it was working properly with a similar example than the one Alan shared (using ReactHookForm). After we merge this, I will talk to him and ensure that it is working as expected for their specific use case. |
…technology/halstack-react into Mil4n0r/resultsettable_checkbox-fix
Checklist
(Check off all the items before submitting)
/lib
directory./website
as needed.Description
When interacting with
Checkbox
or any other changeable element, the page would be set to 1 no matter what the situation were. I have implemented a new logic in order to track changes when adding or removing rows.I still haven't changed the tests because I want the new logic to be validated first, I also have doubts about how to handle both add/remove rows and cases where the data changes entirely (this last one not being taken into account right now).
Closes #1936