Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fonts moved to a stylesheet + added css loader and style loader #1952

Merged
merged 2 commits into from
Apr 18, 2024

Conversation

Jialecl
Copy link
Collaborator

@Jialecl Jialecl commented Apr 17, 2024

Checklist
(Check off all the items before submitting)

  • Build process is done without errors. All tests pass in the /lib directory.
  • Self-reviewed the code before submitting.
  • Meets accessibility standards.
  • Added/updated documentation to /website as needed.
  • Added/updated tests as needed.

Purpose
Font imports changed to avoid scenarios in which they are not correctly loaded.

Description
Font imports were added to a stylesheet.
css-loader and style-loader added to load correctly the style sheet.

Closes #1948

@Mil4n0r Mil4n0r self-assigned this Apr 18, 2024
@Mil4n0r Mil4n0r self-requested a review April 18, 2024 06:10
@raquelarrojo raquelarrojo self-requested a review April 18, 2024 07:29
Copy link
Collaborator

@Mil4n0r Mil4n0r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

@Jialecl Jialecl merged commit a0fadb7 into master Apr 18, 2024
4 checks passed
@Jialecl Jialecl deleted the jialecl-cssLoader branch April 18, 2024 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with Paginator of ResultsetTable in release 12.0.0 (missing icons?)
3 participants