Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fonts css reverted back and changed the approach to load fonts #1957

Merged
merged 1 commit into from
Apr 19, 2024

Conversation

Jialecl
Copy link
Collaborator

@Jialecl Jialecl commented Apr 19, 2024

Checklist
(Check off all the items before submitting)

  • Build process is done without errors. All tests pass in the /lib directory.
  • Self-reviewed the code before submitting.
  • Meets accessibility standards.
  • Added/updated documentation to /website as needed.
  • Added/updated tests as needed.

Purpose
The fonts css approach did not work in nextjs apps, so we decided in a temporal workaround.
This new approach was tested in app, website, storybook and an empty app with vite.

@GomezIvann GomezIvann self-requested a review April 19, 2024 09:54
@GomezIvann GomezIvann merged commit 8d625da into master Apr 19, 2024
3 of 4 checks passed
@GomezIvann GomezIvann deleted the jialecl-fontsWorkaround branch April 19, 2024 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants