Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Tooltip component #1968

Merged
merged 37 commits into from
May 8, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
37 commits
Select commit Hold shift + click to select a range
656933e
Started working on the Tooltip component
Mil4n0r Apr 24, 2024
7c542d4
Completed tooltip component
Mil4n0r Apr 25, 2024
a819a20
Added functional testing for tooltip component
Mil4n0r Apr 25, 2024
fab2b9f
Applied new tooltip to existing components
Mil4n0r Apr 26, 2024
dc6e4a5
Changed tooltip implementation
Mil4n0r Apr 26, 2024
0896d09
Added storybook interaction
Mil4n0r Apr 26, 2024
033177d
Removed unneeded code
Mil4n0r Apr 26, 2024
1a7ef18
Fixed format
Mil4n0r Apr 26, 2024
f86a8df
Fixed format
Mil4n0r Apr 26, 2024
7706ada
Fixed multi-line tooltips
Mil4n0r Apr 26, 2024
a4113b8
Added improvements to Tooltip based on feedback from DSDR
Mil4n0r Apr 29, 2024
3770541
Merge branch 'master' of github.com:dxc-technology/halstack-react int…
Mil4n0r Apr 29, 2024
74a3e1e
Fixed old version of storybook test library
Mil4n0r Apr 29, 2024
002d5eb
Fixed tooltip tests and swapped prop names
Mil4n0r Apr 30, 2024
a44e8eb
Changed prop name title to label
Mil4n0r Apr 30, 2024
057e5a5
Modified max-width for tooltip
Mil4n0r Apr 30, 2024
fc0ab3f
Merge branch 'master' into Mil4n0r/tooltip-component
Mil4n0r Apr 30, 2024
64d3e43
Modified spacing in stories
Mil4n0r Apr 30, 2024
73c2198
Merge branch 'Mil4n0r/tooltip-component' of github.com:dxc-technology…
Mil4n0r Apr 30, 2024
ec5931d
Added support for table actionicons tooltips
Mil4n0r Apr 30, 2024
ee9a451
Restored changes outside Tooltip component
Mil4n0r Apr 30, 2024
97dcced
Tooltip size const removed
Mil4n0r May 2, 2024
6921981
Removed unneeded type in Tooltip
Mil4n0r May 2, 2024
76560b2
Added arrow SVG
Mil4n0r May 2, 2024
26b1e48
Added a story for each tooltip scenario
Mil4n0r May 6, 2024
0eaab71
Removed redundant tests
Mil4n0r May 7, 2024
b3fff2a
Removed await from hover/unhover
Mil4n0r May 7, 2024
48f8179
Removed await from hover/unhover
Mil4n0r May 7, 2024
5674933
Done separated tests for tooltip
Mil4n0r May 7, 2024
7b9bac7
Removed unused import
Mil4n0r May 7, 2024
941064a
Added fixes from review
Mil4n0r May 7, 2024
fe75741
Deleted build storybook log
Mil4n0r May 7, 2024
6696dfe
Fixed spacing for tooltip snapshot
Mil4n0r May 7, 2024
2c9fc53
Merge branch 'master' into Mil4n0r/tooltip-component-adaptations
Mil4n0r May 7, 2024
26c5ca2
Changed margin of large text tooltip
Mil4n0r May 7, 2024
95cf66d
Merge branch 'Mil4n0r/tooltip-component-adaptations' of github.com:dx…
Mil4n0r May 7, 2024
ec78392
Merge branch 'master' into Mil4n0r/tooltip-component-adaptations
Jialecl May 8, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/.prettierrc
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
{
"printWidth": 120
"printWidth": 120,
"trailingComma": "es5"
}
4 changes: 2 additions & 2 deletions lib/.storybook/test-runner.ts
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ const a11yConfig: TestRunnerConfig = {
page.setViewportSize(parsedViewportSizes);
}
} catch (err) {
console.error("Problem when loading the Story Context");
console.error("Problem when loading the Story Context -> ", err);
}
},
async postVisit(page, context) {
Expand All @@ -47,7 +47,7 @@ const a11yConfig: TestRunnerConfig = {
rules: storyContext?.parameters?.a11y?.config?.rules,
});
} catch (err) {
console.error("Problem when loading the Story Context");
console.error("Problem when loading the Story Context -> ", err);
}

await checkA11y(page, "#storybook-root", {
Expand Down