Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed resultSet typing for rows #1997

Merged
merged 9 commits into from
May 20, 2024
Merged

Fixed resultSet typing for rows #1997

merged 9 commits into from
May 20, 2024

Conversation

Mil4n0r
Copy link
Collaborator

@Mil4n0r Mil4n0r commented May 15, 2024

Checklist
(Check off all the items before submitting)

  • Build process is done without errors. All tests pass in the /lib directory.
  • Self-reviewed the code before submitting.
  • Meets accessibility standards.
  • Added/updated documentation to /website as needed.
  • Added/updated tests as needed.

Description
Typing for rows inside resultsetTable was incorrect.

Closes #1996

@Mil4n0r Mil4n0r marked this pull request as draft May 15, 2024 10:43
@Mil4n0r Mil4n0r marked this pull request as ready for review May 15, 2024 11:17
@Jialecl Jialecl self-requested a review May 16, 2024 14:13
@Jialecl Jialecl self-assigned this May 16, 2024
@Jialecl Jialecl merged commit 66c6f2c into master May 20, 2024
4 checks passed
@Jialecl Jialecl deleted the Mil4n0r/resultset-typing branch May 20, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix incorrect typing in ResultsetTable
2 participants