Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a final step in final module to remove PAT #42

Open
ojacques opened this issue Mar 27, 2020 · 8 comments
Open

Add a final step in final module to remove PAT #42

ojacques opened this issue Mar 27, 2020 · 8 comments
Labels
🍒 Low hanging fruit Good issues for new users to learn about the project and get involved. ⚡ Enhancement New feature or request good first issue Help wanted A contribution is welcome to address this issue 📌 Pinned The issue is pinned 💤 Stale? The issue has not received any recent update

Comments

@ojacques
Copy link
Collaborator

Is your feature request related to a problem? Please describe.

When a student ends all the modules, the GitHub Personal Access Token is no more required. It would be nice to have a final step or maybe a final module to remove the PAT from the account.

@ojacques ojacques added ⚡ Enhancement New feature or request 🍒 Low hanging fruit Good issues for new users to learn about the project and get involved. labels Mar 27, 2020
@pberthonneau pberthonneau added the Help wanted A contribution is welcome to address this issue label Mar 31, 2020
@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in seven days if no further activity occurs.

@github-actions github-actions bot added the 💤 Stale? The issue has not received any recent update label Apr 15, 2020
@ojacques ojacques added 📌 Pinned The issue is pinned and removed 💤 Stale? The issue has not received any recent update labels May 6, 2020
@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in seven days if no further activity occurs.

@github-actions github-actions bot added the 💤 Stale? The issue has not received any recent update label May 21, 2020
@pberthonneau pberthonneau added good first issue and removed 💤 Stale? The issue has not received any recent update labels Jun 16, 2020
@github-actions
Copy link

github-actions bot commented Jul 7, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in seven days if no further activity occurs.

@github-actions github-actions bot added the 💤 Stale? The issue has not received any recent update label Jul 7, 2020
@cpswan
Copy link
Contributor

cpswan commented Dec 17, 2020

Does the PAT we're asking the students to make have sufficient scope to delete itself?

@pberthonneau
Copy link
Contributor

On github.com, there is no API endpoint to add or remove a PAT. This has to be done through the UI which can only be accessed with login/password.

@ojacques
Copy link
Collaborator Author

We may now be able to leverage oauth to get a Personal Access Token. This just released GO library could do what we need and offer a better experience: https://github.com/cli/oauth

@tom-halpin
Copy link
Contributor

We provided the instructions for the student to create the PAT, I think it would be a good idea to add a Final module.

Ideas

1 - Thank you for taking the Dojo
2 - Very high level summary of what was covered(basically a list of the modules and a list of the learning objectives per module
3 - Small quiz (two questions or 3 questions per module, students would be informed which modules they may need to revisit
4 - Housekeeping - Instructions to delete the PAT and why

@pberthonneau
Copy link
Contributor

pberthonneau commented Dec 21, 2020

We could also invite people to share feedback in the new discussion tab.
It is enabled with default in online-devops-dojo, but we could instead enable it in about-devops-dojo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍒 Low hanging fruit Good issues for new users to learn about the project and get involved. ⚡ Enhancement New feature or request good first issue Help wanted A contribution is welcome to address this issue 📌 Pinned The issue is pinned 💤 Stale? The issue has not received any recent update
Projects
None yet
Development

No branches or pull requests

4 participants