Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Personal access tokens echoed to screen in URLs #86

Open
cpswan opened this issue Dec 15, 2020 · 0 comments
Open

Personal access tokens echoed to screen in URLs #86

cpswan opened this issue Dec 15, 2020 · 0 comments

Comments

@cpswan
Copy link
Contributor

cpswan commented Dec 15, 2020

Describe the bug
We added the option to supress the echoing of personal access tokens (PATs) when initially pasted, but those tokens are later formed into URLs that are echoed to the console.

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://youtu.be/zNShWuKdWMQ?t=533 - see that token isn't echoed by prepare.sh -s
  2. Go to https://youtu.be/zNShWuKdWMQ?t=848 to see token echoed to console as part of the URL

Expected behavior
Tokens should not be echoed to console (by not being placed into URLs in the way they are at the moment).

Screenshot
If applicable, add screenshots to help explain your problem.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant