Resolve #6779 by not rendering the share button in the c11y part. Fix…

… missing translation.
dxos · May 23, 2024 · 9dfec16 · 9dfec16
1 parent fc62b61
commit 9dfec16
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 2 deletions.
diff --git a/packages/apps/plugins/plugin-deck/src/components/DeckLayout.tsx b/packages/apps/plugins/plugin-deck/src/components/DeckLayout.tsx
@@ -154,7 +154,9 @@ const NodePlankHeading = ({
         )}
       </ActionRoot>
       <PlankHeading.Label classNames='grow'>{label}</PlankHeading.Label>
-      {node && <Surface role='navbar-end' direction='inline-reverse' data={{ object: node.data, part }} />}
+      {node && part[0] !== 'complementary' && (
+        <Surface role='navbar-end' direction='inline-reverse' data={{ object: node.data, part }} />
+      )}
       {/* NOTE(thure): Pinning & unpinning are temporarily disabled */}
       <PlankHeading.Controls
         part={part}

diff --git a/packages/apps/plugins/plugin-deck/src/translations.ts b/packages/apps/plugins/plugin-deck/src/translations.ts
@@ -26,6 +26,7 @@ export default [
         'open comments label': 'Open comments',
         'error fallback message': 'Unable to open this item',
         'plank heading fallback label': 'Untitled',
+        'actions menu label': 'Options',
       },
     },
   },

diff --git a/packages/apps/plugins/plugin-space/src/components/ShareSpaceButton.tsx b/packages/apps/plugins/plugin-space/src/components/ShareSpaceButton.tsx
@@ -19,5 +19,9 @@ export const ShareSpaceButton = ({ spaceKey }: { spaceKey: PublicKey }) => {
 export const ShareSpaceButtonImpl = ({ onClick }: { onClick: () => void }) => {
   const { t } = useTranslation(SPACE_PLUGIN);
 
-  return <Button onClick={onClick}>{t('share space label')}</Button>;
+  return (
+    <Button onClick={onClick} classNames='mli-1'>
+      {t('share space label')}
+    </Button>
+  );
 };