-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(halo): member roles #6656
feat(halo): member roles #6656
Conversation
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 81fb707. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 4 targets
Sent with 💌 from NxCloud. |
0685a0b
to
121dc3d
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6656 +/- ##
==========================================
- Coverage 68.28% 67.78% -0.51%
==========================================
Files 793 740 -53
Lines 23200 22740 -460
Branches 3789 3708 -81
==========================================
- Hits 15843 15415 -428
+ Misses 5450 5431 -19
+ Partials 1907 1894 -13 ☔ View full report in Codecov by Sentry. |
Details
Changes:
Credential
may containparentCredentialIds
that are signed.SpaceMember.Role.MEMBER
->SpaceMember.Role.EDITOR
.dxos.halo.credentials.Revocation
credential removed,SpaceMember.Role.REMOVED
added instead.SpaceMember.Role.OWNER
added.parentCredentialIds
array is empty it's deleted from the object for compatibility with oldCredential
s.SpaceMember
credential we setparentCredentialIds
to ids of all the "leaf"SpaceMember
credentials we knew about at the moment. Leaf credentials are those to which noparentCredentialIds
are pointing.MemberStateMachine
insertsSpaceMember
credentials into aCredentialGraph
.Credential
was appended to the graph (the new credential has all the previously-leaf credentials in its parent references) we simply apply an update on top of the previous state.Minor changes:
context
is a function we evaluate it only if we're going to actually log the statement. Avoids doing unnecessary work for debug logs which do object transformations.range
supports a generator second argument.TODO (in another PR):
Client
API for role management.re #6386