Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(halo): updateMemberRole API #6714

Merged
merged 8 commits into from
May 20, 2024
Merged

Conversation

yarolegovich
Copy link
Member

Details

  • Removed PresenceState.REMOVED.
  • Extended SpaceMember structure with role (possibly equal to REMOVED).
  • Added permission checks for invitation creation and role update calls (fail-fast).
  • Updated Presence to maintain of map of online peers grouped by identityKey.
  • Implemented updateMemberRole rpc on SpacesService, accessible through SpaceProxy.
  • Added the code to disconnect from removed peers in DataSpaceManager (in response to role changes). Topology update is also triggered to reconnect to peers who potentially became re-added.

re #6387

Copy link

codecov bot commented May 17, 2024

Codecov Report

Attention: Patch coverage is 85.98131% with 15 lines in your changes are missing coverage. Please review.

Project coverage is 67.36%. Comparing base (f752aaa) to head (5e64ab3).

Current head 5e64ab3 differs from pull request most recent head 59a40f7

Please upload reports for the commit 59a40f7 to get more accurate results.

Files Patch % Lines
.../packlets/invitations/space-invitation-protocol.ts 64.28% 4 Missing and 1 partial ⚠️
...services/src/packlets/spaces/data-space-manager.ts 88.88% 0 Missing and 3 partials ⚠️
...ore/mesh/teleport-extension-gossip/src/presence.ts 92.00% 0 Missing and 2 partials ⚠️
...ent-services/src/packlets/spaces/spaces-service.ts 87.50% 2 Missing ⚠️
...ackages/core/echo/echo-pipeline/src/space/space.ts 80.00% 1 Missing ⚠️
packages/sdk/client/src/echo/space-proxy.ts 66.66% 1 Missing ⚠️
packages/sdk/react-client/src/echo/useMembers.ts 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6714      +/-   ##
==========================================
- Coverage   67.98%   67.36%   -0.63%     
==========================================
  Files         804      725      -79     
  Lines       24459    22924    -1535     
  Branches     4037     3729     -308     
==========================================
- Hits        16629    15443    -1186     
+ Misses       5827     5607     -220     
+ Partials     2003     1874     -129     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yarolegovich yarolegovich changed the title Yarolegovich/role change handling feat(halo): updateMemberRole API May 17, 2024
@yarolegovich yarolegovich enabled auto-merge (squash) May 20, 2024 13:30
@yarolegovich yarolegovich merged commit 3b535c7 into main May 20, 2024
6 checks passed
@yarolegovich yarolegovich deleted the yarolegovich/role-change-handling branch May 20, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant