Integration test for Rails 5 #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 8569321061Details
💛 - Coveralls |
mec
force-pushed
the
chore/integration-tests-for-rails-5
branch
2 times, most recently
from
cee37bd
to
1719211
Compare
This is the extra work required to get our simple integration test running in Rails 5. It boils down to remove the assumed reliance on Chrome for system tests that we do not use anyway, we use the rack_test driver for ease. Please note, these test are expected to FAIL on the 1x branch, they will only pass on the new v2 branch.
mec
force-pushed
the
chore/integration-tests-for-rails-5
branch
from
1719211
to
f0e3f30
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the extra work required to get our simple integration test
running in Rails 5.
It boils down to remove the assumed reliance on Chrome for system tests
that we do not use anyway, we use the rack_test driver for ease.
Please note, these test are expected to FAIL on the 1x branch, they will
only pass on the new v2 branch.