(Refactor): Move updateHash() and loadGitignore() to update()

To minimise duplication.
dxw · Feb 10, 2017 · 8d47603 · 8d47603
1 parent 8caec0e
commit 8d47603
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/src/Dependencies/Updater.php b/src/Dependencies/Updater.php
@@ -59,6 +59,8 @@ public function updateAll()
 
     private function update(array $dependencies)
     {
+        $this->updateHash();
+        $this->loadGitignore();
         $count = 0;
         foreach ($dependencies as $type => $typeDependencies) {
             foreach ($typeDependencies as $dep) {
@@ -84,8 +86,6 @@ private function prepareForUpdate()
         if ($result->isErr()) {
             return $result;
         }
-        $this->updateHash();
-        $this->loadGitignore();
         return \Result\Result::ok();
     }
 

diff --git a/tests/dependencies/updater_test.php b/tests/dependencies/updater_test.php
@@ -26,7 +26,7 @@ private function getGitignore(array $get, array $save, /* bool */ $saveIgnores,
         return $gitignore;
     }
 
-    private function getWhippetLockWritable(array $addDependency, /* string */ $hash, /* string */ $path, array $getDependencies)
+    private function getWhippetLockWritable(array $addDependency, /* string */ $hash, /* string */ $path, array $getDependencies, /* boolean */ $setHash = true)
     {
         $whippetLock = $this->getMockBuilder('\\Dxw\\Whippet\\Files\\WhippetLock')
         ->disableOriginalConstructor()
@@ -41,7 +41,7 @@ private function getWhippetLockWritable(array $addDependency, /* string */ $hash
             $addDependency
         );
 
-        $whippetLock->expects($this->exactly(1))
+        $whippetLock->expects($this->exactly($setHash === true ? 1 : 0))
         ->method('setHash')
         ->with($hash);
 
@@ -683,7 +683,7 @@ public function testUpdateSingleNoMatch()
         $this->addFactoryCallStatic('\\Dxw\\Whippet\\Files\\WhippetJson', 'fromFile', $dir.'/whippet.json', \Result\Result::ok($whippetJson));
 
 
-        $whippetLock = $this->getWhippetLockWritable([], sha1('foobar'), null, []);
+        $whippetLock = $this->getWhippetLockWritable([], sha1('foobar'), null, [], false);
         $this->addFactoryCallStatic('\\Dxw\\Whippet\\Files\\WhippetLock', 'fromFile', $dir.'/whippet.lock', \Result\Result::ok($whippetLock));
 
         $dependencies = new \Dxw\Whippet\Dependencies\Updater(