Can't compile with scons on Windows

[Mako88]

When trying to compile I get this error:

DXX-Archive.3: checking version of C++ compiler 'g++' ...
ValueError: close_fds is not supported on Windows platforms if you redirect stdin/stdout/stderr:
  File "C:\MinGW\msys\1.0\home\Sewanee\dxx-rebirth\SConstruct", line 3693:
    d.init(substenv)
  File "C:\MinGW\msys\1.0\home\Sewanee\dxx-rebirth\SConstruct", line 3413:
    DXXProgram.static_archive_construction[self.user_settings.builddir] = DXXArchive(self.user_settings)
  File "C:\MinGW\msys\1.0\home\Sewanee\dxx-rebirth\SConstruct", line 3130:
    self.configure_environment()
  File "C:\MinGW\msys\1.0\home\Sewanee\dxx-rebirth\SConstruct", line 3154:
    getattr(conf, k.name)()
  File "c:\Python27\Lib\site-packages\scons-2.4.0\SCons\SConf.py", line 668:
    ret = self.test(context, *args, **kw)
  File "C:\MinGW\msys\1.0\home\Sewanee\dxx-rebirth\SConstruct", line 411:
    most_recent_error = self._check_cxx_works(context)
  File "C:\MinGW\msys\1.0\home\Sewanee\dxx-rebirth\SConstruct", line 477:
    self._show_tool_version(context, CXX, 'C++ compiler')
  File "C:\MinGW\msys\1.0\home\Sewanee\dxx-rebirth\SConstruct", line 436:
    v = StaticSubprocess.get_version_head(tool)
  File "C:\MinGW\msys\1.0\home\Sewanee\dxx-rebirth\SConstruct", line 75:
    v = _qcall('%s %s' % (cmd, '--version'), stderr=subprocess.PIPE)
  File "C:\MinGW\msys\1.0\home\Sewanee\dxx-rebirth\SConstruct", line 72:
    return _pcall(_shlex_split(args),stderr)
  File "C:\MinGW\msys\1.0\home\Sewanee\dxx-rebirth\SConstruct", line 67:
    p = subprocess.Popen(args, executable=args[0], stdout=subprocess.PIPE, stderr=stderr, close_fds=True)
  File "c:\Python27\lib\subprocess.py", line 667:
    raise ValueError("close_fds is not supported on Windows")

[Mako88]

@vLKp Anyway you could fix this soonish? I just switched from Linux to Windows so all the beta builds (and the official release) will be built on Windows now.

[vLKp]

I will fix it when I get back to working on Rebirth. It looks like this has been broken since I committed Cache scons subprocess calls in April 2015.

[Mako88]

Thanks man! :) You're the most bestest!

[vLKp]

A developer-only feature set close_fds=True ("Explicit is better than implicit.") when it was added. Cache scons subprocess calls refactored several subprocess calls and happened to copy from the one which explicitly requested close_fds=True. This worked fine on Linux systems, where closing descriptors is easy. It broke on Windows because of the strange way that process creation works there.