Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broken save game icons (mini screenshots) after 8aadb4be5b5336290f74c9205da7f4297be40e3c #354

Closed
Havner opened this issue Nov 5, 2017 · 3 comments
Closed

Broken save game icons (mini screenshots) after 8aadb4be5b5336290f74c9205da7f4297be40e3c #354

Havner opened this issue Nov 5, 2017 · 3 comments
Assignees
@vLKp
Labels
bug
Milestone
0.60

Comments

@Havner
Copy link
Contributor

Havner commented Nov 5, 2017

When saving a game and then loading it back the mini screenshot icons (on the savegame list screen) are complete white. Sometimes they flicker with some random data.
@Havner
Copy link
Contributor Author

Havner commented Nov 5, 2017

screen shot 2017-11-06 at 00 37 26

Not necessarily white, sometime brown. But always garbage.

@vLKp vLKp added the bug label Nov 6, 2017
@vLKp vLKp self-assigned this Nov 6, 2017
@vLKp vLKp added this to the 0.60 milestone Nov 6, 2017
vLKp added a commit that referenced this issue Nov 6, 2017
@vLKp
Fix savegame thumbnail previews
ff49e94 
Transposed arguments to fill_n caused rls_stretch_scanline to write
garbage to the preview buffer.

Reported-by: Havner <#354>
Fixes: 8aadb4b ("Use fill_n instead of inline loop to write scanline")
@vLKp
Copy link
Contributor

vLKp commented Nov 6, 2017

First bad commit is Use fill_n instead of inline loop to write scanline.

Fix savegame thumbnail previews fixes this for me.

@vLKp vLKp changed the title [OSX on latest git: 09963e8b5] broken save game icons (mini screenshots) Broken save game icons (mini screenshots) after 8aadb4be5b5336290f74c9205da7f4297be40e3c Nov 6, 2017
@Havner
Copy link
Contributor Author

Havner commented Nov 6, 2017 •
edited
Loading

Confirmed fixed. Thank you.

@Havner Havner closed this as completed Nov 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vLKp vLKp

Labels
bug
Projects
None yet
Milestone
0.60
Development

No branches or pull requests
2 participants
@vLKp @Havner