Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace manual delays by frame time measurement #750

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

midzer
Copy link

@midzer midzer commented Jan 9, 2024

Hi,

According to good dialogue in #746, here's mentioned PR to improve render performance (should give more FPS) by replacing all manual delays.

Code is tested for Descent 1 Shareware.

Have a nice week
midzer

@vLKp
Copy link
Contributor

vLKp commented Jan 14, 2024

From an initial read of this work, it looks like you removed delay calls in a variety of places, but only added the ability to sleep in the OpenGL-specific rendering path. Will that not cause the SDL-only build to spin, since it does not use the OpenGL renderer? It looks like SDL-only may not even build, since you changed the declaration for gr_flip, but did not update the implementation in similar/arch/sdl/gr.cpp to match the new signature.

@midzer
Copy link
Author

midzer commented Jan 25, 2024

Yeah, I forgot the SDL-only path.

Gonna try if I get it to work and push necessary changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants