Observer mode: show ping times for observed player #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… their ping times are
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves feature request #8. The multiplayer kill list is normally not shown in observer mode because we have an enhanced scoreboard visible at the top of the screen. However, when observing an individual player, it would be useful to see what ping times they're getting to everyone else; the observer mode scoreboard does not show this information. To resolve this, I've allowed the kill list to be shown when observing an individual player, and tweaked the ping times shown so that they reflect what the player sees, not what the observer sees.
@roncli - is this a reasonable implementation of the feature request in your view? I'd add you as a reviewer but GitHub doesn't seem to let me do that - maybe it's related to project memberships or something...
Adding pings to the player cards seems like it'd get messy, but I guess I could go that route if I can find some space to squeeze it in.