Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix k6 load tests so post bodies will be json #1384

Merged
merged 1 commit into from
Feb 24, 2024
Merged

fix k6 load tests so post bodies will be json #1384

merged 1 commit into from
Feb 24, 2024

Conversation

dyc3
Copy link
Owner

@dyc3 dyc3 commented Feb 24, 2024

By default, k6/http will encode post requests as x-www-form-urlencoded. This can result in boolean values getting interpreted by the monolith as strings.

Related: #1339

By default, k6/http will encode post requests as `x-www-form-urlencoded`. This can result in boolean values getting interpreted by the monolith as strings.

Related: #1339
Copy link
Contributor

coderabbitai bot commented Feb 24, 2024

Important

Auto Review Skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository.

To trigger a single review, invoke the @coderabbitai review command.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

@dyc3
Copy link
Owner Author

dyc3 commented Feb 24, 2024

@coderabbitai Create an issue to start using zod to parse and validate HTTP requests

Copy link
Contributor

coderabbitai bot commented Feb 24, 2024

@dyc3: The issue to start using zod for parsing and validating HTTP requests has been successfully created. You can view and track the progress here.

Analysis chain
Scripts executed

The following scripts were executed for the analysis:


Script:

#!/bin/bash
# Create a GitHub issue for integrating zod for HTTP request validation.
gh issue create --title "Integrate zod for HTTP request validation" --body "This issue tracks the task of integrating zod to parse and validate HTTP requests in the project, as discussed in https://github.com/dyc3/opentogethertube/pull/1384. Using zod will help in ensuring that the HTTP requests conform to the expected schema, enhancing the robustness and security of request handling."

Length of output: 443

Copy link

codecov bot commented Feb 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.1663%. Comparing base (3f7dee2) to head (ac96aaa).

Additional details and impacted files
@@             Coverage Diff             @@
##             master      #1384   +/-   ##
===========================================
  Coverage   54.1663%   54.1663%           
===========================================
  Files           158        158           
  Lines         24650      24650           
  Branches       1437       1437           
===========================================
  Hits          13352      13352           
  Misses        11241      11241           
  Partials         57         57           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

cypress bot commented Feb 24, 2024

Passing run #1096 ↗︎

0 73 1 0 Flakiness 0

Details:

Merge ac96aaa into 3f7dee2...
Project: OpenTogetherTube Commit: 12b4f9bdce ℹ️
Status: Passed Duration: 03:29 💡
Started: Feb 24, 2024 6:03 PM Ended: Feb 24, 2024 6:07 PM

Review all test suite changes for PR #1384 ↗︎

@dyc3 dyc3 merged commit adca404 into master Feb 24, 2024
22 checks passed
@dyc3 dyc3 deleted the fix-k6-requests branch February 24, 2024 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant